Skip to content

Conversation

@navba-MSFT
Copy link
Contributor

fixes #20870

Adding Tag parameter to New-AzFrontDoorWafPolicy

This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

…WafPolicy

fixes #20870 

Adding Tag parameter to New-AzFrontDoorWafPolicy

This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. 
Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.
@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this parameter should be added into Update-AzFrontDoorWafPolicy as well. @navba-MSFT what's your thought

@BethanyZhou BethanyZhou added needs-author-feedback More information is needed from author to address the issue. and removed needs-revision labels Feb 15, 2023
@navba-MSFT
Copy link
Contributor Author

navba-MSFT commented Feb 15, 2023

I'm wondering if this parameter should be added into Update-AzFrontDoorWafPolicy as well. @navba-MSFT what's your thought

@BethanyZhou For updating the tags alone, the recommendation would be to use Update-AzTag command.
For New-AzFrontDoorWafPolicy the tag was added since the customer wanted it right during the creation for the Front Door WAF policy resource.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Feb 15, 2023

we'd better allow customer to update other properties together with tags.

@BethanyZhou BethanyZhou merged commit 547da57 into main Feb 15, 2023
@BethanyZhou BethanyZhou deleted the navba-MSFT-patch-9 branch February 15, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-author-feedback More information is needed from author to address the issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New-AzFrontDoorWafPolicy Tags

4 participants