-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Az.DataProtection] Adding support for Immutable vaults #20723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb9ddd5 to
cbb6d39
Compare
|
@isra-fel : Please review this PR and do not merge yet. There might be a one last change before merge |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could use an example of Update-AzDataProtectionBackupVault to demonstrate how to use New-AzDataProtectionSoftDeleteSettingObject though.
Replaced Get-InstalledModule with Get-Module -ListAvailable Added support for Immutable backup vaults Added Cross subscription restore flag for backup vaults Added Soft delete setting for backup vaults Added New-AzDataProtectionSoftDeleteSettingObject command
Re-recorded test cases Updated SignatureIssues.csv
added examples for New/Update backup vault re-recorded test case
@isra-fel , updated the soft delete parameter by individually taking two parameters instead of a new soft delete command. Updated examples accordingly. Please review now |
|
I've triggered "azure-powershell - Code Gen" to verify stuff like the examples. |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.