Skip to content

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Jan 11, 2023

Description

this bug fix accounts for shebang and comments in both linux and windows

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@isra-fel isra-fel self-assigned this Jan 12, 2023
@isra-fel
Copy link
Member

@grizzlytheodore you want to tag someone from your team to review the business logic?

@isra-fel
Copy link
Member

BTW, please give me something that I can put into ChangeLog.md when I generate the code to main branch.

@grizzlytheodore
Copy link
Contributor Author

@isra-fel this was tested on my Linux, windows machine, and also checked with Viv, the feature owner.

For Changelog: "Updated Set-AzVMRunCommand and Set-AzVmssRunCommand ScriptLocalPath parameter set to work with Linux and with files that have comments."

@isra-fel isra-fel merged commit e4558aa into generation Jan 13, 2023
@isra-fel isra-fel deleted the cplat-VmRC branch January 13, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants