Decouple Sql project with Storage in ASM; #1965
Conversation
EmmaZhu
commented
Mar 18, 2016
EmmaZhu
commented
- Decouple Sql project with Commands.Storage in ASM
- Fix issue of several azure storage file cmdlets with useless parameter sets.
- Update DataMovement library reference to the one published in nuget.
… is not specified, by default, the cmdlet doesn't validate downloaded file's content consistance.
…when generating sas token in cmdlets.
|
@EmmaZhu please pull from upstream dev and resolve conflicts. |
| HelpMessage = "The Azure Storage Container to place the blob in.")] | ||
| [ValidateNotNull] | ||
| public AzureStorageContainer StorageContainer { get; set; } | ||
| public CloudBlobContainer StorageContainer { get; set; } |
There was a problem hiding this comment.
This will be a breaking change for this cmdlet. What are the differences in creating a CloudBlobContainer versus an AzureStorageContainer?
There was a problem hiding this comment.
It is. I've confirmed with Sql team and they've agreed with this change. Current, this parameter doesn't support pipeline, so the change won't break any piping scenarios. CloudBlobContainer can be got with Get-AzureStorageContainer cmdlet too, I've updated examples in help.
|
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/602/ |
|
on demand test run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/604/ |
|
On demand test run: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/607/ |
|
On demand test run: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/609 |
|
This looks great once the module publish issue is resolved. |
|
The module publish issue has already been resolved by Hovsep and I've merged his change. |
|
@EmmaZhu thanks, just verifying with a new signing job and we can merge this. |
4 participants
