Skip to content

Updated two new Sql test cases invocation from RunPowerShellTest to TestRunner.RunTestScript#19015

Merged
BethanyZhou merged 1 commit intoAzure:mainfrom
vidai-msft:main
Jul 22, 2022
Merged

Updated two new Sql test cases invocation from RunPowerShellTest to TestRunner.RunTestScript#19015
BethanyZhou merged 1 commit intoAzure:mainfrom
vidai-msft:main

Conversation

@vidai-msft
Copy link
Contributor

Description

We have migrated Sql test project from test controller to test runner but there were still 2 new test cases not updated.
Changed the invocation from original RunPowerShellTest method which is not valid to TestRunner.RunTestScript.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BethanyZhou BethanyZhou merged commit 214c0b9 into Azure:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants