Skip to content

Fix "save as pfx" example#19003

Merged
BethanyZhou merged 2 commits intoAzure:mainfrom
odegroot:patch-1
Jul 22, 2022
Merged

Fix "save as pfx" example#19003
BethanyZhou merged 2 commits intoAzure:mainfrom
odegroot:patch-1

Conversation

@odegroot
Copy link
Contributor

Description

Fixes the "save as pfx" example, as discussed in issue #18251.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@ghost ghost added the customer-reported label Jul 21, 2022
@ghost
Copy link

ghost commented Jul 21, 2022

Thank you for your contribution odegroot! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Jul 21, 2022

CLA assistant check
All CLA requirements met.

@BethanyZhou
Copy link
Contributor

Verified these changes, looks good.

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit 26c148f into Azure:main Jul 22, 2022
@odegroot odegroot deleted the patch-1 branch July 29, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants