Skip to content

NetworkWatcher : Adding VMSS as a source in ConnectionMonitor.#19002

Merged
BethanyZhou merged 4 commits intoAzure:network-2022-01-01from
kumaam:network-2022-01-01
Jul 22, 2022
Merged

NetworkWatcher : Adding VMSS as a source in ConnectionMonitor.#19002
BethanyZhou merged 4 commits intoAzure:network-2022-01-01from
kumaam:network-2022-01-01

Conversation

@kumaam
Copy link
Contributor

@kumaam kumaam commented Jul 21, 2022

Description

NetworkWatcher : Adding VMSS as a source in ConnectionMonitor.

Notes :

  • Added new Testcase for NetworkWatcher - ConnectionMonitor with VMSS as a source.
  • Updated ConnectionMonitor wiki file.

Testing Details
Ran below commands to test the changes and connection monitor gets created successfully

$SourceEndpointVMSSObject = New-AzNetworkWatcherConnectionMonitorEndpointObject -Name "vmssEndpoint" -AzureVMSS -ResourceId "/subscriptions/9cece3e3-0f7d-47ca-af0e-9772773f90b7/resourceGroups/Piyush-OMS-Test/providers/Microsoft.Compute/virtualMachineScaleSets/vmsscuseuap" 

$testGroup = New-AzNetworkWatcherConnectionMonitorTestGroupObject -Name testGroupName -TestConfiguration $testConfiguration -Source $SourceEndpointVMSSObject -Destination $destinationEndpoint

$cm = New-AzNetworkWatcherConnectionMonitor -NetworkWatcherName $networkWatcherName -ResourceGroupName "NetworkWatcherRG" -Name $testname -TestGroup $testGroup

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@kumaam kumaam requested a review from MikhailTryakhov as a code owner July 21, 2022 13:01
@kumaam kumaam changed the title Network 2022 01 01 NetworkWatcher : Adding VMSS as a source in ConnectionMonitor. Jul 21, 2022
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants