Skip to content

Changed IdentifyTopFatFlows to EnableFatFlowLogging on the backend model#18992

Merged
BethanyZhou merged 4 commits intoAzure:network-2022-01-01from
Gizachew-Eshetie:update-EnableFatFlowLogging-flag
Jul 25, 2022
Merged

Changed IdentifyTopFatFlows to EnableFatFlowLogging on the backend model#18992
BethanyZhou merged 4 commits intoAzure:network-2022-01-01from
Gizachew-Eshetie:update-EnableFatFlowLogging-flag

Conversation

@Gizachew-Eshetie
Copy link
Contributor

@Gizachew-Eshetie Gizachew-Eshetie commented Jul 20, 2022

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@BethanyZhou
Copy link
Contributor

Please check Commands.Network.Test.ScenarioTests.AzureFirewallTests.TestAzureFirewallCRUDIdentifyTopFatFlow [FAIL], this test case failed.

@Gizachew-Eshetie
Copy link
Contributor Author

TestAzureFirewallCRUDIdentifyTopFatFlow

@BethanyZhou can you please point me where exactly the test case failed, tried to run it locally and it passed, trying to know why it is failing in the pipelines.

@BethanyZhou
Copy link
Contributor

See details in Script Stack Trace: at Assert-AreEqual, D:\a\1\s\src\Network\Network.Test\bin\Debug\netcoreapp3.1\Assert.ps1: line 274
at Test-AzureFirewallCRUDIdentifyTopFatFlow, D:\a\1\s\src\Network\Network.Test\bin\Debug\netcoreapp3.1\ScenarioTests\AzureFirewallTests.ps1: line 1903
at , : line 1
: Target: Assertion failed because expected 'true' does not match actual ''

@Gizachew-Eshetie Gizachew-Eshetie force-pushed the update-EnableFatFlowLogging-flag branch from 6a4b5a7 to 716dfff Compare July 22, 2022 22:01
@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants