Skip to content

[Synapse] Set 'ResourceGroupName' parameter as optional for 'Set-AzSynapseSqlAuditSetting'#18983

Merged
BethanyZhou merged 1 commit intoAzure:mainfrom
yanjungao718:synapse-resourcegroupname-optional
Jul 21, 2022
Merged

[Synapse] Set 'ResourceGroupName' parameter as optional for 'Set-AzSynapseSqlAuditSetting'#18983
BethanyZhou merged 1 commit intoAzure:mainfrom
yanjungao718:synapse-resourcegroupname-optional

Conversation

@yanjungao718
Copy link
Contributor

Set 'ResourceGroupName' parameter as optional for 'Set-AzSynapseSqlAuditSetting'

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@yanjungao718 yanjungao718 requested a review from wonner July 20, 2022 06:23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add check for if WorkspaceName is not null or empty, because the WorkspaceName is a mandatory parameter only in WorkspaceParameterSet parameter set.

Copy link
Contributor Author

@yanjungao718 yanjungao718 Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the judgement to the end might solve the problem, @wonner is that ok?

@yanjungao718 yanjungao718 force-pushed the synapse-resourcegroupname-optional branch from c570e6c to 2d4ac5a Compare July 21, 2022 01:42
@BethanyZhou
Copy link
Contributor

@Nickcandy , could you help review?

Copy link
Contributor

@Nickcandy Nickcandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit fc6d777 into Azure:main Jul 21, 2022
@yanjungao718 yanjungao718 deleted the synapse-resourcegroupname-optional branch August 29, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants