[Synapse] Set 'ResourceGroupName' parameter as optional for 'Set-AzSynapseSqlAuditSetting'#18983
Merged
BethanyZhou merged 1 commit intoAzure:mainfrom Jul 21, 2022
Conversation
wonner
reviewed
Jul 20, 2022
Contributor
There was a problem hiding this comment.
Need to add check for if WorkspaceName is not null or empty, because the WorkspaceName is a mandatory parameter only in WorkspaceParameterSet parameter set.
Contributor
Author
There was a problem hiding this comment.
move the judgement to the end might solve the problem, @wonner is that ok?
c570e6c to
2d4ac5a
Compare
wonner
approved these changes
Jul 21, 2022
Contributor
|
@Nickcandy , could you help review? |
Contributor
|
/azp run azure-powershell - security-tools |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set 'ResourceGroupName' parameter as optional for 'Set-AzSynapseSqlAuditSetting'
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.