Skip to content

Update CI logic#18980

Merged
BethanyZhou merged 3 commits intomainfrom
wyunchi/fix/ci-pipeline
Jul 20, 2022
Merged

Update CI logic#18980
BethanyZhou merged 3 commits intomainfrom
wyunchi/fix/ci-pipeline

Conversation

@wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Jul 20, 2022

Description

  1. Change the fallback logic of Github api ratelimit failure.
  2. Move the setting of SelectModuleList from pipeline variable to .ci-config.json.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@wyunchi-ms wyunchi-ms force-pushed the wyunchi/fix/ci-pipeline branch from 6829450 to 47eae00 Compare July 20, 2022 03:27
@wyunchi-ms wyunchi-ms changed the title trigger CI Update CI logic Jul 20, 2022
@BethanyZhou BethanyZhou merged commit 7e41f3a into main Jul 20, 2022
@BethanyZhou BethanyZhou deleted the wyunchi/fix/ci-pipeline branch July 20, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants