Skip to content

Fix some issues of ci-pipeline#18973

Merged
BethanyZhou merged 1 commit intomainfrom
wyunchi/fix/ci-pipeline
Jul 19, 2022
Merged

Fix some issues of ci-pipeline#18973
BethanyZhou merged 1 commit intomainfrom
wyunchi/fix/ci-pipeline

Conversation

@wyunchi-ms
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@wyunchi-ms wyunchi-ms force-pushed the wyunchi/fix/ci-pipeline branch from 7106308 to 0aadf8e Compare July 19, 2022 09:06
@BethanyZhou BethanyZhou merged commit fb3fdf9 into main Jul 19, 2022
@BethanyZhou BethanyZhou deleted the wyunchi/fix/ci-pipeline branch July 19, 2022 13:06
@BethanyZhou BethanyZhou mentioned this pull request Jul 19, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants