-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add new Account SAS Token cmdlet, and add IPacl/Protocal support to B/T/Q/F new SAS cmdlets #1828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…StorageAccountSAS cmdlet.
|
Hi @blueww, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
| private string accessPolicyIdentifier; | ||
|
|
||
| [Parameter(HelpMessage = "Permissions for a container. Permissions can be any not-empty subset of \"rwdl\".", | ||
| ParameterSetName = SasPermissionParameterSet)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
@blueww I'm excited to see this feature. It looks like a little bit of rethinking input parmater types is necessary to make the cmdlets usable - the user should not have to separately create a complex .Net type in order to use the cmdlet. Also, need to see some test coverage and I assume the help update covers the new cmdlets. |
|
Hi Mark, Thanks for the review and comments! I have replied all your comments. Summarize as below:
Please let me know if you have other questions or comments! |
… Attempted to divide by zero
| <SpecificVersion>False</SpecificVersion> | ||
| <HintPath>..\..\..\packages\Newtonsoft.Json.6.0.8\lib\net45\Newtonsoft.Json.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="System.Spatial, Version=5.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have changes here?
Add new Account SAS Token cmdlet, and add IPacl/Protocal support to B/T/Q/F new SAS cmdlets
*Change the Help xml file for the cmdlets update. (The help text is pending Tamra review as he is OOF, might have another PR for Help Text change from Tamra later)
*The Help xml has many changes as it's re-generated from the PSHelp Edit Tool. You can find all Help text change (and conclusion of each change) from:
HelpChange.docx.