Skip to content

Add commandlets for installing, removing, getting and testing the Azu… #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hovsepm merged 7 commits into from
Feb 23, 2016
Merged

Add commandlets for installing, removing, getting and testing the Azu… #1821

hovsepm merged 7 commits into from
Feb 23, 2016

Conversation

@MSSedusch
Copy link
Member

@MSSedusch MSSedusch commented Feb 16, 2016

…re Enhanced Monitoring extension

@azurecla
Copy link

azurecla commented Feb 16, 2016

Hi @MSSedusch, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (sedusch). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link

azuresdkci commented Feb 16, 2016

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented Feb 17, 2016

@azuresdkci test this please

@hovsepm
Copy link
Contributor

hovsepm commented Feb 17, 2016

@MSSedusch please pull from upstream dev branch.

@hovsepm
Copy link
Contributor

hovsepm commented Feb 22, 2016

@azuresdkci add to whitelist

@MSSedusch
Copy link
Member Author

MSSedusch commented Feb 22, 2016

I fixed the offline test. Can you rerun the test suite?

hovsepm
hovsepm reviewed Feb 23, 2016
View reviewed changes
src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/AEMExtensionTests.ps1 Outdated
$vmname = $vm.Name

# Get with not extension
$extension = Get-AzureRmVMAEMExtension -ResourceGroupName $rgname -VMName $vmname
Copy link
Contributor

@hovsepm hovsepm Feb 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSSedusch, please align the indentation in this file.

@hovsepm
Copy link
Contributor

hovsepm commented Feb 23, 2016

@MSSedusch Please add license header to all files in the PR

hovsepm pushed a commit that referenced this pull request Feb 23, 2016
Merge pull request #1821 from MSSedusch/dev
332bada 
Add commandlets for installing, removing, getting and testing the Azu…
@hovsepm hovsepm merged commit 332bada into Azure:dev Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MSSedusch @azurecla @azuresdkci @hovsepm