Add AksTestRunner and replace TestController #17962
Conversation
vidai-msft
left a comment
vidai-msft
left a comment
There was a problem hiding this comment.
Please check the review comments and change the code accordingly.
| .WithNewRmModules (helper => new[] | ||
| { | ||
| helper.RMProfileModule, | ||
| helper.GetRMModulePath("AzureRM.Aks.psd1") |
There was a problem hiding this comment.
Update from AzureRM.Aks.psd1 to Az.Aks.psd1
| AzureSession.Instance.DataStore.WriteFile(Path.Combine(home, ".azure", "acsServicePrincipal.json"), jsonOutput); | ||
| } | ||
| } | ||
| ).WithManagementClients( |
There was a problem hiding this comment.
Remove the invocation of WithManagementClients()
| .Build(); | ||
| } | ||
|
|
||
| private static ContainerServiceClient GetContainerServiceClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
| { | ||
| return context.GetServiceClient<ContainerServiceClient>(); | ||
| } | ||
| private MicrosoftGraphClient GetGraphManagementClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
| { | ||
| return context.GetServiceClient<MicrosoftGraphClient>(); | ||
| } | ||
| private static AuthorizationManagementClient GetAuthorizationManagementClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
| { | ||
| return context.GetServiceClient<AuthorizationManagementClient>(); | ||
| } | ||
| private static ResourceManagementClient GetInternalResourceManagementClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
vidai-msft
left a comment
vidai-msft
left a comment
There was a problem hiding this comment.
WithMockContextAction() still not removed.
ziyuezh576
force-pushed
the
AksTestRunner
branch
from
2c8d703 to
098f4cd
Compare
ziyuezh576
force-pushed
the
AksTestRunner
branch
from
caecbf4 to
098f4cd
Compare
| @@ -0,0 +1,87 @@ | |||
| using System; | |||
3 participants
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added