-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add Opt-out for DSC Extension DataCollection #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @TravisEz13, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it should be using SwitchParameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need three states enable, disable and not specified. a switch parameter does not allow all three states, or possible future states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Thanks.
|
Looks OK to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it should be using SwitchParameter.
|
LGTM. Thanks. |
Add Opt-out for DSC Extension DataCollection
Attempting again PR #1234
Reviewed by @eshaparmar and I tested locally in our CI system and manually.
Existing regression automation:
https://github.com/Azure/azure-powershell/blob/dev/src/ServiceManagement/Compute/Commands.ServiceManagement.Test/UnitTests/Cmdlets/IaaS/Extensions/DSC/DscExtensionSettingsSerializerTests.cs
https://github.com/Azure/azure-powershell/blob/dev/src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/DscExtensionTests.ps1
#1739