Skip to content

Conversation

@azurecla
Copy link

Hi @TravisEz13, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (tplunk). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it should be using SwitchParameter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need three states enable, disable and not specified. a switch parameter does not allow all three states, or possible future states.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks.

@huangpf
Copy link
Contributor

huangpf commented Jan 29, 2016

Looks OK to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it should be using SwitchParameter.

@hovsepm
Copy link
Contributor

hovsepm commented Jan 29, 2016

@hyonholee
Copy link
Contributor

LGTM. Thanks.

hovsepm pushed a commit that referenced this pull request Jan 29, 2016
Add Opt-out for DSC Extension DataCollection
@hovsepm hovsepm merged commit d3e43d0 into Azure:release-1.2.0 Jan 29, 2016
@eshaparmar eshaparmar deleted the DataCollectionRb2 branch March 15, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants