Skip to content

Split Az.Network Examples #17250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BethanyZhou merged 3 commits into from
Mar 1, 2022
Merged

Split Az.Network Examples #17250

BethanyZhou merged 3 commits into from
Mar 1, 2022

Conversation

@CaptainFanZzz
Copy link
Contributor

@CaptainFanZzz CaptainFanZzz commented Feb 23, 2022

Description

Split Az.Network Examples

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

v-yuzhichen
v-yuzhichen reviewed Feb 25, 2022
View reviewed changes
src/Network/Network/help/New-AzLoadBalancerBackendAddressPoolConfig.md Outdated
## EXAMPLES

### Example 1: Create a backend address pool configuration for a load balancer
```
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add powershell

src/Network/Network/help/New-AzIpConfigurationBgpPeeringAddressObject.md Outdated

## EXAMPLES

### 1: Create a AzIpConfigurationBgpPeeringAddressObject
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to “Examplex 1”

src/Network/Network/help/New-AzFirewallPolicySqlSetting.md Outdated

## EXAMPLES

### 1. Create a SQL setting that allows SQL server redirect mode traffic
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to “Example 1”

src/Network/Network/help/New-AzFirewallPolicyIntrusionDetectionSignatureOverride.md Outdated

## EXAMPLES

### Example 1: 1. Create intrusion detection with signature overrides
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to delete “1.”

src/Network/Network/help/New-AzFirewallPolicyIntrusionDetectionBypassTraffic.md Outdated

## EXAMPLES

### Example 1: 1. Create bypass traffic with specific port and source address
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to delete “1.”

src/Network/Network/help/Remove-AzDdosProtectionPlan.md Outdated
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "powershell"

src/Network/Network/help/New-AzVHubRoute.md Outdated
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete lines 70 and 72

src/Network/Network/help/Remove-AzDdosProtectionPlan.md Outdated
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete lines 38 and 40

src/Network/Network/help/Set-AzBastion.md Outdated
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete line 69 and 71

src/Network/Network/help/Set-AzVirtualNetworkGateway.md Outdated
Copy link
Contributor

@v-yuzhichen v-yuzhichen Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put it in an output

@CaptainFanZzz CaptainFanZzz removed their assignment Feb 28, 2022
@BethanyZhou BethanyZhou merged commit 2bf21cc into Azure:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ziyuezh576 ziyuezh576 Awaiting requested review from ziyuezh576

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

1 more reviewer

@v-yuzhichen v-yuzhichen v-yuzhichen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-yuzhichen v-yuzhichen

Labels

Doc - Reference needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaptainFanZzz @v-yuzhichen @BethanyZhou