Skip to content

Conversation

@haocs
Copy link

@haocs haocs commented Jan 14, 2016

Added trailing backslash to PSMoudlePath during msi installation.

@markcowl
Copy link
Member

@haocs haocs changed the title Added trailing backslash to PSMoudlePath during msi installation. [#111344356]Added trailing backslash to PSMoudlePath during msi installation. Jan 15, 2016
@haocs
Copy link
Author

haocs commented Jan 15, 2016

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why *listener", why not make this class ServiceClientTracingInterceptor?

@markcowl
Copy link
Member

@haocs If possible, we should add in amock test that verifies debug messages are written to the queue

haocs pushed a commit that referenced this pull request Jan 19, 2016
[#111344356]Added trailing backslash to PSMoudlePath during msi installation.
@haocs haocs merged commit 31ae30f into Azure:dev Jan 19, 2016
@haocs haocs deleted the trailingslash-fix branch January 19, 2016 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants