Skip to content

Conversation

@BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Nov 10, 2021

Description

  • Removed warning messages
  • Removed duplicated cmdlets
  • [Breaking change] Migrated from AAD Graph to Microsoft Graph
  • [Breaking change] Changed the return id in PSDenyAssignment from Guid string to fully qualified id
  • Allowed Id in Get-AzDenyAssignment to accept fully qualified id

Migration guide:
Id in Get-AzDenyAssignment still accept guid, no change for input.
The output of Get-AzDenyAssignment changes: Id changes from "22704996-fbd0-4ab1-8625-722d897825d2" -> "/subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f/providers/Microsoft.Authorization/denyAssignments/22704996-fbd0-4ab1-8625-722d897825d2"

Get-AzDenyAssignment
Id                      : /subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f/providers/Microsoft.Authorization/denyAssignments/22704996-fbd0-4ab1-8625-722d897825d2
DenyAssignmentName      : Test deny assignment 1
Description             : Test deny assignment for PS cmdlets
Actions                 : {foo/*}
NotActions              : {foo/*/read}
DataActions             : {foo/*}
NotDataActions          : {}
Scope                   : /subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f
DoNotApplyToChildScopes : False
Principals              : {
                          DisplayName:  All Principals
                          ObjectType:   SystemDefined
                          ObjectId:     00000000-0000-0000-0000-000000000000
                          }
ExcludePrincipals       : {
                          DisplayName:  testuser
                          ObjectType:   User
                          ObjectId:     f8d526a0-54eb-4941-ae69-ebf4a334d0f0
                          }
IsSystemProtected       : True

Benefit for this change: scope can be included in Id

To get guid as before: Id.TrimEnd('/').Substring(Id.LastIndexOf('/') + 1)

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou marked this pull request as draft November 10, 2021 07:40
@BethanyZhou BethanyZhou marked this pull request as ready for review November 10, 2021 07:54
@BethanyZhou BethanyZhou added the Contains Breaking Change This PR contains breaking change label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contains Breaking Change This PR contains breaking change Waiting for CI :shipit:

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants