-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Initial commit for the Websites commandlets for ARM #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
Hi @NaveenGoli, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
src/AzurePowershell.sln
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove this project?
|
Is the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra new lines
|
@azuresdkci add to whitelist |
|
I have incorporated all the feedback changes. please review.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have some extra \n throughout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
|
looks good |
|
Will this be merged? AFAI can see, Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests has no relation to websites code changes.. please let me know what the next steps are.. |
|
Not until the tests are passing. The reason New-AzureResourceGroup is not being found will need to be investigated. |
|
re-test this please. |
|
its passing on my local machine.. Assemblies Run C:\GitHUb\azure-powershell\src\ResourceManager\Sql\Commands.Sql.Test\bin\Debug\Microsoft.Azure.Commands.Sql.Test.dll Summary Tests run: 3 Skipped: 2, Run time: 57.330s Skipped tests Skipped Skipped All tests Click test class name to expand/collapse test details 57.070s |
… project to avoid the sql test failures due to module load issues.
|
when will this pull be taken in? I was under the impression it will happen today? |
Initial commit for the Websites commandlets for ARM
|
There is one issue with this merge, the project does not build now as it is using the deprecated property of AzurePSCmdlet 'CurrentContext', where it should have been Profile.Context? |
|
+Mark Sent from my Windows Phone From: Yadav Bhattarai (Microsoft)mailto:[email protected] There is one issue with this merge, the project does not build now as it is using the deprecated property of AzurePSCmdlet 'CurrentContext', where it should have been Profile.Context? Reply to this email directly or view it on GitHub: |
No description provided.