-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update tests + escape paramters passed to clurun by (bash) wrapper script #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the "cli namespace" used from azure to testcli Update build script to pick any .lx file instead of limiting to only azure.lx
|
Hi @johanste, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should tab be 4 spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
From: Yugang Wang [mailto:[email protected]]
Sent: Thursday, December 17, 2015 4:18 PM
To: Azure/azure-powershell [email protected]
Cc: Johan Stenberg [email protected]
Subject: Re: [azure-powershell] Update tests + escape paramters passed to clurun by (bash) wrapper script (#1519)
In src/CLU/Microsoft.ScenarioTests.CLU/testrunner.bathttps://github.com//pull/1519#discussion_r47980597:
@@ -0,0 +1,33 @@
+SETLOCAL EnableExtensions
+ECHO Test return code success case
+call testclu success show 2> out.error
+REM We expect that the commands above succeed (return 0)
+IF %ERRORLEVEL% NEQ 0 (
ECHO "Expected error level 0 for success, got " %ERRORLEVEL%
should tab be 4 spaces?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1519/files#r47980597.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tab is also not right in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ick. That file shouldn’t have been included. Removed.
From: Yugang Wang [mailto:[email protected]]
Sent: Thursday, December 17, 2015 4:42 PM
To: Azure/azure-powershell [email protected]
Cc: Johan Stenberg [email protected]
Subject: Re: [azure-powershell] Update tests + escape paramters passed to clurun by (bash) wrapper script (#1519)
In src/CLU/Microsoft.ScenarioTests.CLU/out.txthttps://github.com//pull/1519#discussion_r47982181:
+IF %ERRORLEVEL% NEQ 0 (
ECHO "Expected error level 0 for success, got " %ERRORLEVEL%EXIT /B 1+)
+ECHO Test return codes non terminating error case
+call testclu success show --generatenonterminatingerror true 2> out.error
+IF %ERRORLEVEL% NEQ 1 (
ECHO "Expected error level 1 for non-terminating error, got " %ERRORLEVEL%EXIT /B 1+)
+ECHO Test return codes terminating error case
+call testclu success show --generateterminatingerror true 2> out.error
+IF %ERRORLEVEL% NEQ 2 (
ECHO "Expected error level 2 for terminating error, got " %ERRORLEVEL%
the tab is also not right in this file
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1519/files#r47982181.
Update tests + escape paramters passed to clurun by (bash) wrapper script
No description provided.