Skip to content

Gateway LoadBalancer property ParameterSetName requirement removal #15108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msJinLei merged 2 commits into from
May 28, 2021
Merged

Gateway LoadBalancer property ParameterSetName requirement removal #15108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c593d1
fix
May 26, 2021
1fdbca7
fix
May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Network/Network.Test/ScenarioTests/LoadBalancerTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2366,9 +2366,9 @@ function Test-GatewayLoadBalancer-ConsumerLb
$frontendConsumerName = Get-ResourceName
$domainNameLabel = Get-ResourceName

$rglocation = Get-ProviderLocation ResourceManagement
$rglocation = "eastus2euap"
$resourceTypeParent = "Microsoft.Network/loadBalancers"
$location = Get-ProviderLocation $resourceTypeParent
$location = "eastus2euap"

try
{
Expand All @@ -2388,7 +2388,7 @@ function Test-GatewayLoadBalancer-ConsumerLb

# Create Consumer LoadBalancer
$lbConsumer = New-AzLoadBalancer -Name $lbConsumerName -ResourceGroupName $rgname -Location $location -Sku Standard
Add-AzLoadBalancerFrontendIpConfig -GatewayLoadBalancerId $frontendProvider.Id -LoadBalancer $lbConsumer -Name $frontendConsumerName
Add-AzLoadBalancerFrontendIpConfig -PublicIpAddress $publicipConsumer -GatewayLoadBalancerId $frontendProvider.Id -LoadBalancer $lbConsumer -Name $frontendConsumerName
$lbConsumer = Set-AzLoadBalancer -LoadBalancer $lbConsumer

$expectedLbConsumer = Get-AzLoadBalancer -Name $lbConsumerName -ResourceGroupName $rgname
Expand Down
1 change: 0 additions & 1 deletion ...ted/LoadBalancer/FrontendIPConfiguration/AddAzureRmLoadBalancerFrontendIpConfigCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ public partial class AddAzureRmLoadBalancerFrontendIpConfigCommand : NetworkBase

[Parameter(
Mandatory = false,
ParameterSetName = "SetByResource",
HelpMessage = "The reference of Gateway LoadBalancer Provider resource.",
ValueFromPipelineByPropertyName = true)]
public string GatewayLoadBalancerId { get; set; }
Expand Down
1 change: 0 additions & 1 deletion ...ted/LoadBalancer/FrontendIPConfiguration/SetAzureRmLoadBalancerFrontendIpConfigCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ public partial class SetAzureRmLoadBalancerFrontendIpConfigCommand : NetworkBase

[Parameter(
Mandatory = false,
ParameterSetName = "SetByResource",
HelpMessage = "The reference of Gateway LoadBalancer Provider resource.",
ValueFromPipelineByPropertyName = true)]
public string GatewayLoadBalancerId { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Generated/Models/PSFrontendIPConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public partial class PSFrontendIPConfiguration : PSChildResource
[JsonProperty(Order = 1)]
public PSResourceId PublicIPPrefix { get; set; }
[JsonProperty(Order = 1)]
public PSFrontendIPConfiguration GatewayLoadBalancer { get; set; }
public PSResourceId GatewayLoadBalancer { get; set; }
Copy link
Contributor Author

@matyang22 matyang22 May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually more appropriate.


[JsonIgnore]
public string ZonesText
Expand Down