-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Improve the survey and telemetry #14804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
46fd99c
Collect the command name if it's not supported.
kceiw a87b4af
Show the intercept three times
kceiw 3051efa
Create a cmdlet to open the survey link.
kceiw 916328d
Fix the commandid in the telemetry.
kceiw 3c8e5a1
Improve the telemetry test code.
kceiw 5e28483
Refactor the code to record the history command.
kceiw d2574a4
Updated intercept message, cmdlet and help
dcaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
279 changes: 208 additions & 71 deletions
279
tools/Az.Tools.Predictor/Az.Tools.Predictor.Test/AzPredictorTelemetryTests.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
tools/Az.Tools.Predictor/Az.Tools.Predictor/Commands/OpenAzSurveyLink.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // ---------------------------------------------------------------------------------- | ||
| // | ||
| // Copyright Microsoft Corporation | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // ---------------------------------------------------------------------------------- | ||
|
|
||
| using Microsoft.Azure.PowerShell.Tools.AzPredictor.Utilities; | ||
| using System; | ||
| using System.Diagnostics; | ||
| using System.Globalization; | ||
| using System.IO; | ||
| using System.Management.Automation; | ||
| using System.Text; | ||
| using System.Text.Json; | ||
|
|
||
| namespace Microsoft.Azure.PowerShell.Tools.AzPredictor | ||
| { | ||
| /// <summary> | ||
| /// <para type="synopsis">Cmdlet to open a survey link in the default browser</para> | ||
| /// <para type="description">Use this cmdlet to open a survey link in the default browser</para> | ||
| /// </summary> | ||
| [Cmdlet("Open", "AzSurveyLink"), OutputType(typeof(bool))] | ||
| public sealed class OpenAzSurveyLink : PSCmdlet | ||
| { | ||
| private const string _SurveyLinkFormat = "https://aka.ms/azpredictorisurvey?SessionId={0}&from=cmdlet"; | ||
| /// <summary> | ||
| /// <para type="description">Indicates whether the user would like to receive output. </para> | ||
| /// </summary> | ||
| [Parameter(Mandatory = false)] | ||
| public SwitchParameter PassThru { get; set; } | ||
|
|
||
| /// <inheritdoc/> | ||
| protected override void ProcessRecord() | ||
| { | ||
| var profileSettings = Settings.GetProfileSettings(); | ||
| var surveyId = profileSettings?.SurveyId?.ToString(CultureInfo.InvariantCulture) ?? "000000"; | ||
|
|
||
| var link = string.Format(OpenAzSurveyLink._SurveyLinkFormat, surveyId, CultureInfo.InvariantCulture); | ||
|
|
||
| Console.WriteLine($"Opening survey {link}"); | ||
|
|
||
| // TODO [mahuang] Ouput the link for user to copy/paste in case it's not open in the default browser. | ||
| var processStartInfo = new ProcessStartInfo(); | ||
| processStartInfo.FileName = link; | ||
| processStartInfo.UseShellExecute = true; | ||
|
|
||
| Process.Start(processStartInfo); | ||
|
|
||
| if (profileSettings != null) | ||
| { | ||
| profileSettings.SurveyId = null; | ||
|
|
||
| try | ||
| { | ||
| var fileContent = JsonSerializer.Serialize<Settings>(profileSettings, new JsonSerializerOptions(JsonUtilities.DefaultSerializerOptions) | ||
| { | ||
| WriteIndented = true, | ||
| }); | ||
| var profileSettingFilePath = Settings.GetProfileSettingsFilePath(); | ||
| File.WriteAllText(profileSettingFilePath, fileContent, Encoding.UTF8); | ||
| } | ||
| catch | ||
| { | ||
| // Ignore all exceptions. | ||
| } | ||
| } | ||
|
|
||
| if (PassThru.IsPresent) | ||
| { | ||
| WriteObject(true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to do this now or is this a later thing?