Skip to content

[Tools] Skip test phase if there is no test project in CI pipeline #14243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 6 commits into from
Feb 19, 2021
Merged

[Tools] Skip test phase if there is no test project in CI pipeline #14243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2582533
Fix the issue that cannot fine valid module for Generated module in C…
wyunchi-ms Feb 18, 2021
0d5c800
Fix the issue that Target module fails
wyunchi-ms Feb 18, 2021
fd459e6
Add Debug info for test phase
wyunchi-ms Feb 19, 2021
c096ac9
Merge branch 'master' of https://github.com/Azure/azure-powershell in…
wyunchi-ms Feb 19, 2021
de365a9
Add Debug info for test phase
wyunchi-ms Feb 19, 2021
1f35bc9
Add Debug info for test phase
wyunchi-ms Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@
PropertyName="SubTasks" />
</CreateProperty>
<CreateProperty
Value="@(BuildCsprojList->Split(`;`)->Count())">
Value="@(TestCsprojList->Split(`;`)->Count())">
<Output
TaskParameter="Value"
PropertyName="IsBuildListEmpty" />
PropertyName="IsTestListEmpty" />
</CreateProperty>
</Target>

Expand Down Expand Up @@ -311,13 +311,13 @@
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(DockerTools)/CleanArtifacts.ps1 -Docker $(DockerRoot) &quot;" />
</Target>

<Target Name="Test">
<Target Name="Test" DependsOnTargets="FilterBuild">
<Message Importance="high" Text="Running check in tests..." />
<MakeDir Directories="$(TestOutputDirectory)" ContinueOnError="false" />

<!-- https://github.com/Microsoft/msbuild/issues/3157#issuecomment-378002971 -->
<!-- https://github.com/xunit/xunit/issues/1154#issuecomment-405366373 -->
<Exec Command="dotnet test $(RepoArtifacts)Azure.PowerShell.sln --filter &quot;AcceptanceType=CheckIn%26RunType!=DesktopOnly&quot; --configuration $(Configuration) --framework $(TestFramework) --logger trx --results-directory &quot;$(TestOutputDirectory)&quot;" />
<Exec Command="dotnet test $(RepoArtifacts)Azure.PowerShell.sln --filter &quot;AcceptanceType=CheckIn%26RunType!=DesktopOnly&quot; --configuration $(Configuration) --framework $(TestFramework) --logger trx --results-directory &quot;$(TestOutputDirectory)&quot; --verbosity d" />

<OnError ExecuteTargets="TestFailureErrorMessage" />
</Target>
Expand Down
2 changes: 1 addition & 1 deletion tools/CreateFilterMappings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function Add-ProjectDependencies
[string]$SolutionPath
)

$CommonProjectsToIgnore = @("Authenticators", "ScenarioTest.ResourceManager", "TestFx", "Tests" )
$CommonProjectsToIgnore = @("ScenarioTest.ResourceManager", "TestFx", "Tests" )

$ProjectDependencies = @()
$Content = Get-Content -Path $SolutionPath
Expand Down