Skip to content

[DataFactory]Fix the command Invoke-AzDataFactoryV2Pipeline for SupportsShouldProcess issue #13755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyunchi-ms merged 2 commits into from
Dec 16, 2020
Merged

[DataFactory]Fix the command Invoke-AzDataFactoryV2Pipeline for SupportsShouldProcess issue #13755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f473f
[DataFactory]Fix the command `Invoke-AzDataFactoryV2Pipeline` for Sup…
Jingshu918 Dec 16, 2020
58bc79c
Update Changelog.md
wyunchi-ms Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DataFactory/DataFactoryV2/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Fixed the command `Invoke-AzDataFactoryV2Pipeline` for SupportsShouldProcess issue

## Version 1.11.2
* Updated ADF .Net SDK version to 4.13.0
Expand Down
1 change: 1 addition & 0 deletions src/DataFactory/DataFactoryV2/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,5 +286,6 @@ internal static class Constants

public const string ActionDescriptionForRemoveEventSubscription = "Unsubscribe the event trigger from external service events.";

public const string ActionDescriptionForInvokePipeline = "Starts a run for \"{0}\" pipeline in the \"{1}\" factory.";
}
}
7 changes: 5 additions & 2 deletions src/DataFactory/DataFactoryV2/Runs/InvokeAzureDataFactoryPipelineCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace Microsoft.Azure.Commands.DataFactoryV2
{
[Cmdlet("Invoke", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataFactoryV2Pipeline", DefaultParameterSetName = ParameterSetNames.ByFactoryNameByParameterFile,SupportsShouldProcess = true), OutputType(typeof(PSPipeline))]
[Cmdlet("Invoke", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataFactoryV2Pipeline", DefaultParameterSetName = ParameterSetNames.ByFactoryNameByParameterFile, SupportsShouldProcess = true), OutputType(typeof(PSPipeline))]
public class InvokeAzureDataFactoryPipelineCommand : DataFactoryBaseCmdlet
{
[Parameter(ParameterSetName = ParameterSetNames.ByPipelineObjectByParameterFile, Position = 0, Mandatory = true, ValueFromPipeline = true,
Expand Down Expand Up @@ -157,7 +157,10 @@ public override void ExecuteCmdlet()
}
}

WriteObject(DataFactoryClient.CreatePipelineRun(ResourceGroupName, DataFactoryName, PipelineName, paramDictionary, ReferencePipelineRunId, isRecovery, StartActivityName, startFromFailure));
if (ShouldProcess(this.ResourceGroupName, string.Format(Constants.ActionDescriptionForInvokePipeline, this.PipelineName, this.DataFactoryName)))
{
WriteObject(DataFactoryClient.CreatePipelineRun(ResourceGroupName, DataFactoryName, PipelineName, paramDictionary, ReferencePipelineRunId, isRecovery, StartActivityName, startFromFailure));
}
}

private Dictionary<string, object> ReadParametersFromJson()
Expand Down