Skip to content

[Azure PowerShell] New service principal warning#13408

Merged
mikefrobbins merged 1 commit intoAzure:masterfrom
rolyon:rolyon-service-principal-warning
Nov 4, 2020
Merged

[Azure PowerShell] New service principal warning#13408
mikefrobbins merged 1 commit intoAzure:masterfrom
rolyon:rolyon-service-principal-warning

Conversation

@rolyon
Copy link
Contributor

@rolyon rolyon commented Nov 3, 2020

Description

Added a warning when creating a new service principal.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel requested a review from mikefrobbins November 4, 2020 08:00
@isra-fel
Copy link
Member

isra-fel commented Nov 4, 2020

@mikefrobbins could you review this change to New-AzADServicePrincipal.md as well? Thanks in advance!

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants