Skip to content

{VirtualWan} Mark rtv1 and rtv2 as to be deprecated#13394

Closed
nagula-ritvika wants to merge 1 commit intoAzure:network-julyfrom
nagula-ritvika:markRtv2AsDeprecating
Closed

{VirtualWan} Mark rtv1 and rtv2 as to be deprecated#13394
nagula-ritvika wants to merge 1 commit intoAzure:network-julyfrom
nagula-ritvika:markRtv2AsDeprecating

Conversation

@nagula-ritvika
Copy link
Contributor

@nagula-ritvika nagula-ritvika commented Nov 2, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@nagula-ritvika nagula-ritvika changed the base branch from network-july to master November 3, 2020 20:42
@nagula-ritvika nagula-ritvika changed the base branch from master to network-july November 3, 2020 20:44
@VeryEarly
Copy link
Collaborator

VeryEarly commented Nov 4, 2020

Hi @nagula-ritvika

Does this PR depends on api 2020-07? It doesn't look like using new SDK

@nagula-ritvika
Copy link
Contributor Author

nagula-ritvika commented Nov 4, 2020 •
edited
Loading

@VeryEarly currently im just marking them as deprecated. Is there a way i can deprecate the ones which were already marked deprecating ? this PR doesnt care about the sdk :)

dedhar
dedhar reviewed Nov 5, 2020
View reviewed changes
src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubRouteCommand.cs
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[CmdletDeprecation(ReplacementCmdletName = "Add-AzVirtualHubRoute")]
[CmdletDeprecation(ReplacementCmdletName = "New-AzVHubRoute")]
Copy link
Contributor

@dedhar dedhar Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the command name change here

Copy link
Contributor Author

@nagula-ritvika nagula-ritvika Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially we marked this deprecated and pointed it to use rtv2, so now replaced it to point to rtv3

@VeryEarly
Copy link
Collaborator

VeryEarly commented Nov 5, 2020

@VeryEarly currently im just marking them as deprecated. Is there a way i can deprecate the ones which were already marked deprecating ? this PR doesnt care about the sdk :)

If so, please re-target your PR to master branch since this network-july branch is dedicated for an OOB release rely on api 2020-07

@nagula-ritvika
Copy link
Contributor Author

nagula-ritvika commented Nov 5, 2020

Creating new pr

@nagula-ritvika
Copy link
Contributor Author

nagula-ritvika commented Nov 5, 2020

#13427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

1 more reviewer

@dedhar dedhar dedhar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dedhar dedhar

@VeryEarly VeryEarly

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nagula-ritvika @VeryEarly @dedhar @azuresdkci

Comments