Skip to content

[App Service] Support for ServiceTag, multi-ip and http-headers in Access Restrictions#13358

Merged
isra-fel merged 1 commit intoAzure:masterfrom
madsd:new-acc-restr-features
Nov 5, 2020
Merged

[App Service] Support for ServiceTag, multi-ip and http-headers in Access Restrictions#13358
isra-fel merged 1 commit intoAzure:masterfrom
madsd:new-acc-restr-features

Conversation

@madsd
Copy link
Contributor

@madsd madsd commented Oct 29, 2020

Description

This PR introduces support for ServiceTags, multi-ip and http-headers in App Service Access Restrictions

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@madsd madsd requested a review from panchagnula October 29, 2020 14:51
@isra-fel isra-fel self-assigned this Nov 2, 2020
@madsd
Copy link
Contributor Author

madsd commented Nov 3, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@madsd
Copy link
Contributor Author

madsd commented Nov 3, 2020

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@madsd
Copy link
Contributor Author

madsd commented Nov 3, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@madsd
Copy link
Contributor Author

madsd commented Nov 4, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@madsd
Copy link
Contributor Author

madsd commented Nov 4, 2020

I have tried multiple times to get the powershell core - Test Windows to complete - but it keeps timing out after 180 minutes. Seems to be Sql Tests taking almost two hours to run.

@isra-fel
Copy link
Member

isra-fel commented Nov 4, 2020

I have tried multiple times to get the powershell core - Test Windows to complete - but it keeps timing out after 180 minutes. Seems to be Sql Tests taking almost two hours to run.

Yeah I've been debugging quite a long time but still no luck to locate the root cause 😕
Anyway you can leave the job to me. I'll make sure this PR get merged in the upcoming release.

@isra-fel isra-fel merged commit a21a690 into Azure:master Nov 5, 2020
@madsd madsd deleted the new-acc-restr-features branch November 12, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants