Skip to content

Update for -HostNames parameter values#13349

Merged
isra-fel merged 1 commit intoAzure:masterfrom
mahortas:patch-1
Nov 2, 2020
Merged

Update for -HostNames parameter values#13349
isra-fel merged 1 commit intoAzure:masterfrom
mahortas:patch-1

Conversation

@mahortas
Copy link
Contributor

@mahortas mahortas commented Oct 28, 2020

Values provided for -Hostnames should be in separate quotation marks

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Values provided for -Hostnames should be in separate quotation marks
@ghost
Copy link

ghost commented Oct 28, 2020

Thank you for your contribution mahortas! We will review the pull request and get back to you soon.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

Looks good to me. @akshaysngupta could you review this as well? Thanks

@isra-fel isra-fel self-assigned this Oct 29, 2020
@akshaysngupta
Copy link
Member

LGTM

Copy link
Member

@akshaysngupta akshaysngupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Nov 2, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel merged commit 527f8bd into Azure:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants