Skip to content

Updated breaking changes warnings in preparation for S177 Milestone PR #13027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 7 commits into from
Sep 22, 2020
Merged

Updated breaking changes warnings in preparation for S177 Milestone PR #13027

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23ae023
New-AzManagedServicesDefinition changes
skayani May 14, 2020
a4c921b
Revert "New-AzManagedServicesDefinition changes"
skayani May 14, 2020
9949fdc
Merge remote-tracking branch 'upstream/master'
skayani Aug 14, 2020
86ddf63
Merge remote-tracking branch 'upstream/master'
skayani Sep 17, 2020
50469a6
Merge remote-tracking branch 'upstream/master'
skayani Sep 21, 2020
f7b74fa
Updated breaking changes warnings
skayani Sep 21, 2020
a1319ef
Fixed typo in changelog
skayani Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ManagedServices/ManagedServices/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Updated breaking change warnings on cmdlets of managed servics assignment and definition

@dramuy dramuy Sep 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

services* typo


## Version 1.1.0
* Added breaking change warnings on cmdlets of managed services assignment and definition
Expand Down
7 changes: 6 additions & 1 deletion src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesAssignment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ public class NewAzureRmManagedServicesAssignment : ManagedServicesCmdletBase
[ScopeCompleter]
public string Scope { get; set; }

[CmdletParameterBreakingChange(
nameOfParameterChanging: "RegistrationDefinitionName",
deprecateByVersion: ManagedServicesUtility.UpcomingVersion,
changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate,
ChangeDescription = ManagedServicesUtility.DeprecatedParameterDescription)]
[Parameter(ParameterSetName = DefaultParameterSet, Mandatory = true, HelpMessage = "The registration definition identifier.")]
[ValidateNotNullOrEmpty]
public string RegistrationDefinitionName { get; set; }
Expand All @@ -50,7 +55,7 @@ public class NewAzureRmManagedServicesAssignment : ManagedServicesCmdletBase
nameOfParameterChanging: "RegistrationDefinitionResourceId",
deprecateByVersion: ManagedServicesUtility.UpcomingVersion,
changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate,
ChangeDescription = ManagedServicesUtility.DeprecatedParameterDescription)]
ReplaceMentCmdletParameterName = "RegistrationDefinitionId")]
[Parameter(ParameterSetName = ByResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "The fully qualified resource id of the registration definition.")]
[ValidateNotNullOrEmpty]
[Alias("ResourceId")]
Expand Down
7 changes: 6 additions & 1 deletion src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
using Microsoft.Azure.Management.ManagedServices.Models;
using Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Extensions;
using Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using Microsoft.WindowsAzure.Commands.Utilities.Common;
using System;
using System.Collections.Generic;
Expand All @@ -23,10 +24,14 @@

namespace Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands
{
[WindowsAzure.Commands.Common.CustomAttributes.GenericBreakingChange(
[GenericBreakingChange(
message: "New mandatory parameter 'DisplayName' will be added to represent a user-friendly name for a registration definition",
deprecateByVersion: ManagedServicesUtility.UpcomingVersion,
changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate)]
[GenericBreakingChange(
message: "New mandatory parameter 'Authorization' will be added to represent a list containing principal IDs and role definition IDs.",
deprecateByVersion: ManagedServicesUtility.UpcomingVersion,
changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate)]
[Cmdlet(
VerbsCommon.New,
Microsoft.Azure.Commands.ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ManagedServicesDefinition",
Expand Down
2 changes: 1 addition & 1 deletion src/ManagedServices/ManagedServices/Extensions/ManagedServicesUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Extensions
public static class ManagedServicesUtility
{
// TODO: Remove these three string as well as breaking changes attributes for Oct. 27th change
public const string UpcomingVersion = "1.0.3";
public const string UpcomingVersion = "1.3.0";
public const string UpcomingVersionReleaseDate = "10/27/2020";
public const string DeprecatedParameterDescription = "Parameter is being deprecated without being replaced";

Expand Down