Resolve dll loading conflict during help generation#12965
Closed
isra-fel wants to merge 1 commit intoAzure:masterfrom
Closed
Resolve dll loading conflict during help generation#12965isra-fel wants to merge 1 commit intoAzure:masterfrom
isra-fel wants to merge 1 commit intoAzure:masterfrom
Conversation
isra-fel
commented
Sep 15, 2020
| continue; | ||
| } | ||
|
|
||
| return Assembly.LoadFrom(dll); |
Member
Author
There was a problem hiding this comment.
Assembly.LoadFrom() will load the dll into the default ALC, so the dlls may conflict.
isra-fel
commented
Sep 15, 2020
| continue; | ||
| } | ||
|
|
||
| return LoadFromAssemblyPath(dll); |
Member
Author
There was a problem hiding this comment.
The assembly resolving logic is the same as before. I just use AssemblyLoadContext.LoadFromAssemblyPath() to load the dll into individual ALCs
Member
Author
|
Root cause: we depend on Microsoft.PowerShell.SDK 6.1.0, which depends on Newtonsoft.Json 11.0.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unblock #12528
IotHub and DeviceProvisioningServices are depending on Newtonsoft.Json 12.0.3, however our tools are using 11.0.2. This caused dll loading conflict during help generation in static analysis.
Solution is to use a custom ALC (assembly loading context) to load each module and their dependencies, so that they won't conflict with each other or common tools.
(No changelog required because it's only code change to tools)
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added