Skip to content

Add suggestion for parameter of PrivateEndPoint cmdlet#12948

Merged
dingmeng-xue merged 17 commits intoAzure:release-2020-10-27from
Youri970410:youri/Network-Suggestion
Oct 21, 2020
Merged

Add suggestion for parameter of PrivateEndPoint cmdlet#12948
dingmeng-xue merged 17 commits intoAzure:release-2020-10-27from
Youri970410:youri/Network-Suggestion

Conversation

@Youri970410
Copy link
Contributor

@Youri970410 Youri970410 commented Sep 14, 2020 •
edited
Loading

Description

  • 1.Add Suggestion to Parameter 'PrivateLinkResourceType'
  • 2.Change the ParameterSet 'ByResource' of the Cmdlet 'Get-AzPrivateEndpointConnection'
  • 3.Add ParameterSet to Cmdlet 'Get-AzPrivateLinkResource'

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Youri added 2 commits September 14, 2020 15:32
Add Suggestion and New ParameterSet
1cab99d 
1.Add Suggestion to Parameter 'PrivateLinkResourceType'
2.Change the ParameterSet 'ByResource' of the Cmdlet 'PrivateLinkResourceType'
3.Add ParameterSet to Cmdlet 'Get-AzPrivateLinkResource'
fix one issue
96a74aa
@ghost
Copy link

ghost commented Sep 14, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@Youri970410 Youri970410 removed the request for review from MikhailTryakhov September 14, 2020 07:50
dingmeng-xue
dingmeng-xue previously approved these changes Sep 28, 2020
View reviewed changes
@dingmeng-xue dingmeng-xue added this to the S176 (2020-10-13) milestone Sep 28, 2020
@dingmeng-xue dingmeng-xue added Contains Breaking Change This PR contains breaking change Do Not Merge 🚫 and removed Waiting for CI :shipit: labels Sep 28, 2020
dingmeng-xue
dingmeng-xue reviewed Oct 19, 2020
View reviewed changes
@dingmeng-xue dingmeng-xue changed the title [Network]Add some suggestion for parameter of cmdlet. Add some suggestion for parameter of PrivateEndPoint cmdlet. Oct 19, 2020
@dingmeng-xue dingmeng-xue changed the title Add some suggestion for parameter of PrivateEndPoint cmdlet. Add suggestion for parameter of PrivateEndPoint cmdlet Oct 19, 2020
@wyunchi-ms
Copy link
Contributor

wyunchi-ms commented Oct 20, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 20, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 20, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 20, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@dingmeng-xue dingmeng-xue changed the base branch from master to release-2020-10-27 October 21, 2020 01:51
@dingmeng-xue dingmeng-xue merged commit f231a35 into Azure:release-2020-10-27 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

Assignees

@dingmeng-xue dingmeng-xue

Labels

Contains Breaking Change This PR contains breaking change Do Not Merge 🚫 needs-review

Projects

None yet

Milestone

S177 (2020-10-27) Major Release

Development

Successfully merging this pull request may close these issues.

5 participants

@Youri970410 @wyunchi-ms @isra-fel @dingmeng-xue @azuresdkci