VM OrchestrationMode: PlatformFaultDomainCount in New-AzVmss and VmssId in New-AzVm

[Sandido]

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[msJinLei]

@Sandido could you rebase to latest the master to suppress the test timeout?

[msJinLei]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[grizzlytheodore]

is there a way to view the instance view of vmss to see this vm added to the vmss?

[Sandido]

@grizzlytheodore , No. This functionality does not exist in PS and CLI due to how the feature is setup on the server side.

[grizzlytheodore]

i believe '?' is not necessary here to be able to pass this parameter as null. Should behave the same when the variable type is 'int', check 'maxprice' parameter. I

[Sandido]

@grizzlytheodore , having the parameter as the nullable int type (int?) removes the need to cast it as a nullable int in the resourceGroup.CreateVirtualMachineScaleSetConfig() call.
MaxPrice does have this cast (double?), so having the parameter int? removes the need for this cast.

[grizzlytheodore]

@Sandido I see. I think it's better to stay consistent on where the parameter is being casted as a nullable variable. Not only in this cmdlet, the variables are casted as a nullable variable in CreateVirtualMachineScaleSetConfig(), but other cmdlets follow the similar structure where '?' is left out at the parameter declaration, and later is casted as nullable when it is being checked with isParameter() method.

[Sandido]

@grizzlytheodore , I changed it as you suggested.

[grizzlytheodore]

should we add vmssId parameter to new-azvmConfig?

[Sandido]

@grizzlytheodore , it is already there, the -vmssId parameter.