Skip to content

[KeyVault] Enhance error handling#12732

Merged
msJinLei merged 1 commit intoAzure:masterfrom
isra-fel:kv-error-msg
Aug 24, 2020
Merged

[KeyVault] Enhance error handling#12732
msJinLei merged 1 commit intoAzure:masterfrom
isra-fel:kv-error-msg

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Aug 23, 2020

Description

Fix #4007
Added a more readable warning message, and a little code formating

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the unnecessary change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@isra-fel
Copy link
Member Author

Reverted those lines. Thanks for reviewing!

@msJinLei msJinLei merged commit 41bab3e into Azure:master Aug 24, 2020
@isra-fel isra-fel deleted the kv-error-msg branch September 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve KeyVault error message when Service Principal does not have correct Graph permissions

4 participants