Skip to content

[Synapse] Add integration runtime management cmdlets #12647

Merged
isra-fel merged 11 commits intoAzure:masterfrom
wonner:IR-dev
Aug 17, 2020
Merged

[Synapse] Add integration runtime management cmdlets #12647
isra-fel merged 11 commits intoAzure:masterfrom
wonner:IR-dev

Conversation

@wonner
Copy link
Contributor

@wonner wonner commented Aug 12, 2020

Description

This change add integration runtime management cmdlets. Here is the commandlet review PR:https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/697

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Aug 12, 2020

Can one of the admins verify this patch?

@wonner wonner requested a review from idear1203 August 12, 2020 03:50
@isra-fel isra-fel self-assigned this Aug 12, 2020
isra-fel
isra-fel requested changes Aug 13, 2020
View reviewed changes
tools/StaticAnalysis/Exceptions/Az.Synapse/SignatureIssues.csv Outdated
Comment on lines +2 to +4
"Microsoft.Azure.PowerShell.Cmdlets.Synapse.dll","Microsoft.Azure.Commands.Synapse.SubmitAzureSynapseSparkJob","Submit-AzSynapseSparkJob","1","8100","Submit-AzSynapseSparkJob Does not support ShouldProcess but the cmdlet verb Submit indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
"Microsoft.Azure.PowerShell.Cmdlets.Synapse.dll","Microsoft.Azure.Commands.Synapse.StartAzureSynapseSparkSession","Start-AzSynapseSparkSession","1","8100","Start-AzSynapseSparkSession Does not support ShouldProcess but the cmdlet verb Start indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
"Microsoft.Azure.PowerShell.Cmdlets.Synapse.dll","Microsoft.Azure.Commands.Synapse.InvokeAzureSynapseSparkStatement","Invoke-AzSynapseSparkStatement","1","8100","Invoke-AzSynapseSparkStatement Does not support ShouldProcess but the cmdlet verb Invoke indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
Copy link
Member

@isra-fel isra-fel Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the suggested action to support shouldprocess for these 3 cmdlets

Copy link
Contributor

@idear1203 idear1203 Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isra-fel These three top issues are existing issues. Can we just suppress these static analysis results because I think the current implementation (without ShouldProcess) are better in user experience?

Copy link
Member

@isra-fel isra-fel Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting shouldprocess means adding two optional parameters -WhatIf and -Confirm. They do not affect default behavior of the cmdlet, but only provide additional information or confirmation when user is uncertain about it. So it is definitely better to support.

Copy link
Contributor

@idear1203 idear1203 Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for your suggestions. I will fix this in a separate PR.

Copy link
Contributor

@idear1203 idear1203 Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isra-fel I created a PR to fix this issue: #12670 . Could you please take a look when you have some time? Thanks in advance.

Copy link
Member

@isra-fel isra-fel Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have approved #12670 and will merge it by today. @wonner please rebase master after it's merged.

isra-fel
isra-fel requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write test cases.

@wonner
Copy link
Contributor Author

wonner commented Aug 14, 2020

Please write test cases.

Have written the test cases. :)

@idear1203 idear1203 mentioned this pull request Aug 14, 2020
Merged
8 tasks
isra-fel
isra-fel approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 49d95fd into Azure:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@idear1203 idear1203 Awaiting requested review from idear1203

Assignees

@isra-fel isra-fel

@wonner wonner

Labels

needs-review needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wonner @adxsdkps @idear1203 @isra-fel @azuresdkci