adding Invoke-AzVmAssessPatch cmdlet. #12608
Closed
grizzlytheodore wants to merge 8 commits intoAzure:masterfrom
Closed
adding Invoke-AzVmAssessPatch cmdlet. #12608grizzlytheodore wants to merge 8 commits intoAzure:masterfrom
grizzlytheodore wants to merge 8 commits intoAzure:masterfrom
Conversation
added 3 commits
August 6, 2020 18:10
Collaborator
|
Can one of the admins verify this patch? |
isra-fel
reviewed
Aug 11, 2020
Member
There was a problem hiding this comment.
Hey @grizzlytheodore , I know this PR has passes design review, but the name Invoke-AzVmAssessPatch might be a little bit misleading. Putting the word "Patch" at the end makes it sound like invoking a patch to me, however what the command actually does it to invoke an assessment, right?
So I suggest Invoke-AzVmPatchAssess or Invoke-AzVmPatchAssessment. To be frank, Get-AzVmPatch could be even better because it describes the nature of the function accurately and simply.
Let me know what you think. Thanks.
cc @VeryEarly
8 tasks
Contributor
Author
|
moved to #12658 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adding Invoke-AzVmAssessPatch cmdlet.
And also updated computecommontest to not have space in the location return for Get-ComputeVmLocation
and added a function that will return an available sku for given subscription, location, and resourcetype.
Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/634
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added