Skip to content

Fix an issue causing Az.psm1 not to generate #12584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 1 commit into from
Aug 6, 2020
Merged

Fix an issue causing Az.psm1 not to generate #12584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/UpdateModules.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ Import-Module "$PSScriptRoot\UpdateModules.psm1"
#################################################>


# Constants (Scopes)
$NetCoreScopes = @('NetCore')
$AzureScopes = @('All', 'Latest', 'ServiceManagement', 'AzureStorage')
$StackScopes = @('All', 'Stack')
Comment on lines +44 to +46
Copy link
Member Author

@isra-fel isra-fel Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause: .psm1 has its own scope. If these variables were defined in a .psm1 file, we cannot access them here, so Update-Netcore (line 52) was skipped.


# Begin
Write-Host "Updating $Scope package (and its dependencies)"
Expand Down
5 changes: 0 additions & 5 deletions tools/UpdateModules.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
#>
$script:TemplateLocation = "$PSScriptRoot\AzureRM.Example.psm1"

# Scopes
$script:NetCoreScopes = @('NetCore')
$script:AzureScopes = @('All', 'Latest', 'ServiceManagement', 'AzureStorage')
$script:StackScopes = @('All', 'Stack')

# Specialty-Scopes used by cmdlets
$script:AzureRMScopes = @('All', 'Latest')
$script:StorageScopes = @('All', 'Latest', 'AzureStorage')
Expand Down