Kusto 2020-06-14 PS version

[astauben]

Description

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/685

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[adxsdkps]

Can one of the admins verify this patch?

[isra-fel]

Hi @astauben please see my inline comments.
Besides, it would be great if you could update the examples with the new parameters.

[isra-fel]

Please ignore tools folder as well and don't check in any files in it

[astauben]

done

[isra-fel]

Some of the files are already checked in, e.g. src/Kusto/tools/Resources/examples/readme.md. Please remove the whole tools/ folder and commit again. Thanks

[astauben]

done

[isra-fel]

Why are test cases all skipped?

[astauben]

we are testing the scenario in the New-AzKustoDatabasePrincipalAssignment file.

[isra-fel]

Can you just delete this file?

[astauben]

done

[astauben]

Hi @astauben please see my inline comments.
Besides, it would be great if you could update the examples with the new parameters.

Hi, @isra-fel Thanks for the review. all comments are resolved

[isra-fel]

LGTM