Encryption at host param by grizzlytheodore · Pull Request #12514 · Azure/azure-powershell

grizzlytheodore · 2020-07-28T16:09:30Z

Description

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/686

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

…nfig and Update-AzVM (#12479) * Adding SecurityProfile and EncryptionAtHost property * Removing deprecated package * Adding back windowsazure.storage library * reverting to version 9.3 * commenting out check for now * commenting out test case * Fixing powershell script * Changing Compute Version for upstream * fixing test * Commenting out test * Adding change log and helpdocs * Testing and other changes

… should be very similar to New-Azvmss.

…e-powershell into encryptionAtHostParam

adxsdkps · 2020-07-28T16:09:32Z

Can one of the admins verify this patch?

src/Compute/Compute/ChangeLog.md

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

fixing type on ln 245

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs

…zure-powershell into haider/encryptionathost

src/Compute/Compute/help/Get-AzVmss.md

src/Compute/Compute/help/Update-AzVM.md

src/Compute/Compute/ChangeLog.md

src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

isra-fel · 2020-07-30T04:55:06Z

Hey, BTW what's the reason for "do not merge" and "do not squash" labels?
I suppose it is OK to squash this PR

removing some description part

removing spaces

…e-powershell into encryptionAtHostParam

grizzlytheodore · 2020-07-30T15:43:08Z

@isra-fel we've resolved all your comments and some more.

for the labels, I had a wrong understanding of squashing, so I've removed that. And for 'do not merge' we have a demo for this feature with the PMs tomorrow and I didn't want this merged yet in case they have some additional suggestions.

isra-fel · 2020-07-31T06:53:58Z

I see. The changes look good to me for now.

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1

grizzlytheodore · 2020-08-03T21:51:26Z

@isra-fel i have removed the Do-not-merge label. Please review and merge!

isra-fel

LGTM!

haagha and others added 19 commits July 16, 2020 23:10

Adding SecurityProfile and EncryptionAtHost property

f5b64a1

Removing deprecated package

e9b862c

Adding back windowsazure.storage library

692dbf7

reverting to version 9.3

6563638

commenting out check for now

9c159ef

commenting out test case

25ef7d7

Fixing powershell script

8283d41

Changing Compute Version for upstream

2803b8f

fixing test

07b6088

Commenting out test

44697f0

Adding change log and helpdocs

221f244

New-Azvmss dev edits

d6ad36b

Testing and other changes

80d7199

Merge branch 'encryptionAtHostParam' into haider/encryptionathost

44e349c

update-azvmss dev edits

8d74d64

New-AzvmssConfig dev edits

5b68675

included test for New-Azvmss and test file. Test for NEw-AzvmssConfig…

1fbab6b

… should be very similar to New-Azvmss.

Merge branch 'encryptionAtHostParam' of https://github.com/Azure/azur…

220c1e8

…e-powershell into encryptionAtHostParam

grizzlytheodore added the Do Not Merge 🚫 label Jul 28, 2020

grizzlytheodore commented Jul 28, 2020

View reviewed changes

src/Compute/Compute/ChangeLog.md Show resolved Hide resolved

grizzlytheodore commented Jul 28, 2020

View reviewed changes

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs Outdated Show resolved Hide resolved

grizzlytheodore commented Jul 28, 2020

View reviewed changes

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs Outdated Show resolved Hide resolved

Update NewAzureRmVmssConfigCommand.cs

04a80bf

fixing type on ln 245

haagha reviewed Jul 28, 2020

View reviewed changes

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs Outdated Show resolved Hide resolved

haagha and others added 4 commits July 28, 2020 13:58

Changing Update-AzVM EncryptionAtHost param to Bool from Switch

55e0b63

Merge branch 'haider/encryptionathost' of https://github.com/haagha/a…

6c6044e

…zure-powershell into haider/encryptionathost

Adding Update-AzVM changes

8448db3

Update ChangeLog.md

f249347

grizzlytheodore removed the Do Not Merge 🚫 label Jul 29, 2020

grizzlytheodore requested review from hyonholee and isra-fel July 29, 2020 17:04

grizzlytheodore added Do Not Merge 🚫 Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. labels Jul 29, 2020

Correct the format of a generated example

79f58bb

isra-fel requested changes Jul 30, 2020

View reviewed changes

isra-fel assigned grizzlytheodore Jul 30, 2020

isra-fel added the needs-revision label Jul 30, 2020

haagha and others added 6 commits July 30, 2020 10:50

Update Update-AzVM.md

262802b

removing some description part

Update NewAzureVMCommand.cs

9ea3e0e

removing spaces

Update ChangeLog.md

cbfe2df

update wildcard support value

ba0e503

Merge branch 'encryptionAtHostParam' of https://github.com/Azure/azur…

da50965

…e-powershell into encryptionAtHostParam

new line edits

ac6acb9

grizzlytheodore removed the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Jul 30, 2020

grizzlytheodore commented Jul 31, 2020

View reviewed changes

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1 Outdated Show resolved Hide resolved

grizzlytheodore commented Jul 31, 2020

View reviewed changes

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1 Show resolved Hide resolved

azuresdkci added the needs-review label Aug 1, 2020

isra-fel removed the needs-review label Aug 3, 2020

haagha and others added 2 commits August 3, 2020 15:25

Fixing a small bug and test case

673119f

Merge branch 'master' into encryptionAtHostParam

92fa3de

grizzlytheodore removed the Do Not Merge 🚫 label Aug 3, 2020

isra-fel approved these changes Aug 4, 2020

View reviewed changes

isra-fel merged commit cd09aea into master Aug 4, 2020

isra-fel deleted the encryptionAtHostParam branch August 4, 2020 05:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encryption at host param#12514

Encryption at host param#12514
isra-fel merged 37 commits intomasterfrom
encryptionAtHostParam

grizzlytheodore commented Jul 28, 2020 •

edited by isra-fel

Loading

Uh oh!

adxsdkps commented Jul 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel commented Jul 30, 2020

Uh oh!

grizzlytheodore commented Jul 30, 2020

Uh oh!

isra-fel commented Jul 31, 2020

Uh oh!

Uh oh!

Uh oh!

grizzlytheodore commented Aug 3, 2020

Uh oh!

isra-fel left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

grizzlytheodore commented Jul 28, 2020 • edited by isra-fel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

adxsdkps commented Jul 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel commented Jul 30, 2020

Uh oh!

grizzlytheodore commented Jul 30, 2020

Uh oh!

isra-fel commented Jul 31, 2020

Uh oh!

Uh oh!

Uh oh!

grizzlytheodore commented Aug 3, 2020

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

grizzlytheodore commented Jul 28, 2020 •

edited by isra-fel

Loading