authenticate token each time client is sending request#12454
Merged
isra-fel merged 9 commits intoAzure:masterfrom Aug 12, 2020
Merged
authenticate token each time client is sending request#12454isra-fel merged 9 commits intoAzure:masterfrom
isra-fel merged 9 commits intoAzure:masterfrom
Conversation
isra-fel
reviewed
Jul 22, 2020
src/Accounts/Authentication/Authentication/RenewingTokenCredential.cs
Outdated
Show resolved
Hide resolved
src/Accounts/Authentication/Authentication/RenewingTokenCredential.cs
Outdated
Show resolved
Hide resolved
Member
|
|
markcowl
requested changes
Jul 24, 2020
Member
markcowl
left a comment
There was a problem hiding this comment.
One minor comment. Also, what validation are we planning to do here?
src/Accounts/Authentication/Authentication/RenewingAccessTokenProvider.cs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
markcowl
requested changes
Jul 29, 2020
src/Accounts/Authentication/Authentication/RenewingAccessTokenProvider.cs
Outdated
Show resolved
Hide resolved
markcowl
approved these changes
Jul 30, 2020
Member
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#11925
#6585
Added delegate function to
RenewingTokenCredentialwhen management client was instantiated.This function will authenticate token (refresh if expired) each time
ProcessHttpRequestAsyncwas called.ProcessHttpRequestAsyncwill be executed before management client tries to send request (include polling for long running operation)https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/mgmtcommon/ClientRuntime.Azure/ClientRuntime.Azure/LRO/LROPollState.cs#L182
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added