Skip to content

String with escape chars cannot be converted into json object #12283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erich-wang merged 3 commits into from
Jul 1, 2020
Merged

String with escape chars cannot be converted into json object #12283

erich-wang merged 3 commits into from
Jul 1, 2020

Conversation

@wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Jun 29, 2020

Fix the issue that string with escape chars cannot be converted into json object.

Fix #11504 .

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms self-assigned this Jun 29, 2020
@adxsdkps
Copy link
Collaborator

adxsdkps commented Jun 29, 2020

Can one of the admins verify this patch?

@wyunchi-ms wyunchi-ms requested a review from erich-wang June 30, 2020 01:35
@wyunchi-ms wyunchi-ms marked this pull request as ready for review June 30, 2020 01:35
@erich-wang erich-wang merged commit 9562911 into master Jul 1, 2020
@wyunchi-ms wyunchi-ms deleted the wyunchi/fix/issue-11504 branch July 3, 2020 08:49
litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
@wyunchi-ms @litchiyangMSFT
String with escape chars cannot be converted into json object (Azure#…
65120cf 
…12283)

* Fix the issue that string with escape chars cannot be converted into json object.

* Change changelog.md

* Change the implement of serializtion and deserializtion of json in automation.

Co-authored-by: wyunchi-ms <[email protected]>
@jeffwmiles jeffwmiles mentioned this pull request Nov 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erich-wang erich-wang erich-wang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wyunchi-ms wyunchi-ms

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get-AzAutomationScheduledRunbook missing parameters when array

4 participants

@wyunchi-ms @adxsdkps @erich-wang