Skip to content

[Storage] Support AllowBlobPublicAccess, MinimumTlsVersion #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 1 commit into from
Jun 28, 2020
Merged

[Storage] Support AllowBlobPublicAccess, MinimumTlsVersion #12252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ApplicationInsights/ApplicationInsights.Test/ApplicationInsights.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.ApplicationInsights" Version="0.3.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.1.0" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/EventGrid/EventGrid.Test/EventGrid.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<PackageReference Include="Microsoft.Azure.Management.EventHub" Version="2.7.0" />
<PackageReference Include="Microsoft.Azure.Management.Relay" Version="2.0.2" />
<PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="2.1.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.1.0" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/OperationalInsights/OperationalInsights.Test/OperationalInsights.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.21.0-preview" />
<PackageReference Include="Microsoft.Azure.OperationalInsights" Version="0.10.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.1.0" />
</ItemGroup>

</Project>
7 changes: 7 additions & 0 deletions src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,5 +204,12 @@ public void TestNewSetAzureStorageAccountRAGZRS()
{
TestRunner.RunTestScript("Test-NewSetAzureStorageAccount_RAGZRS");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestNewSetAzureStorageAccountTLSveresionBlobPublicAccess()
{
TestRunner.RunTestScript("Test-NewSetAzureStorageAccountTLSveresionBlobPublicAccess");
}
}
}
55 changes: 55 additions & 0 deletions src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,4 +1334,59 @@ function Test-NewSetAzureStorageAccount_RAGZRS
# Cleanup
Clean-ResourceGroup $rgname
}
}



<#
.SYNOPSIS
Test Test-NewAzureStorageAccount_TLSveresionBlobPublicAccess
.DESCRIPTION
SmokeTest
#>
function Test-NewSetAzureStorageAccountTLSveresionBlobPublicAccess
{
# Setup
$rgname = Get-StorageManagementTestResourceName;

try
{
# Test
$stoname = 'sto' + $rgname;
$stotype = 'Standard_LRS';
$loc = Get-ProviderLocation_Canary ResourceManagement;
$kind = 'StorageV2'
$tlsVersion = "TLS1_2"

New-AzResourceGroup -Name $rgname -Location $loc;
Write-Output ("Resource Group created")

New-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -SkuName $stotype -MinimumTlsVersion $tlsVersion -AllowBlobPublicAccess $false;

Retry-IfException { $global:sto = Get-AzStorageAccount -ResourceGroupName $rgname -Name $stoname; }
Assert-AreEqual $stoname $sto.StorageAccountName;
Assert-AreEqual $stotype $sto.Sku.Name;
Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
Assert-AreEqual $kind $sto.Kind;
Assert-AreEqual $tlsVersion $sto.MinimumTlsVersion
Assert-AreEqual $false $sto.AllowBlobPublicAccess

$tlsVersion = "TLS1_1"
Set-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -SkuName $stotype -MinimumTlsVersion $tlsVersion -AllowBlobPublicAccess $true ;

Retry-IfException { $global:sto = Get-AzStorageAccount -ResourceGroupName $rgname -Name $stoname; }
Assert-AreEqual $stoname $sto.StorageAccountName;
Assert-AreEqual $stotype $sto.Sku.Name;
Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
Assert-AreEqual $kind $sto.Kind;
Assert-AreEqual $tlsVersion $sto.MinimumTlsVersion
Assert-AreEqual $true $sto.AllowBlobPublicAccess

Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $stoname;
}
finally
{
# Cleanup
Clean-ResourceGroup $rgname
}
}
Loading