Skip to content

Conversation

@michawets
Copy link
Contributor

@michawets michawets commented Jun 18, 2020

When running the example, the diagnostics settings were not applied to the VM, only to the variable stored in the Powershell windows at that moment. No real update was done on the VM.
For the diagnostics to be applied, the cmdlet Update-AzVM still needs to be executed

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

When running the example, the diagnostics settings were not applied to the VM, only to the variable stored in the Powershell windows at that moment. No real update was done on the VM.
For the diagnostics to be applied, the cmdlet Update-AzVM still needs to be executed
@VeryEarly VeryEarly self-assigned this Jun 19, 2020
VeryEarly
VeryEarly previously approved these changes Jun 19, 2020
VeryEarly
VeryEarly previously approved these changes Jun 19, 2020
@VeryEarly
Copy link
Collaborator

looks like the updated vm need to be passed to Update-AzVM, please check my commit and confirm.

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@michawets
Copy link
Contributor Author

michawets commented Jun 19, 2020

looks like the updated vm need to be passed to Update-AzVM, please check my commit and confirm.

Hi @VeryEarly , there are multiple ways to do it 😊.

I double checked my commit, and that will work. I didn't want to change to much on the example, and keep the $VM variable as a single variable

So the $updatedVM variable is actually not needed 😊

@VeryEarly
Copy link
Collaborator

looks like the updated vm need to be passed to Update-AzVM, please check my commit and confirm.

Hi @VeryEarly , there are multiple ways to do it 😊.

I double checked my commit, and that will work. I didn't want to change to much on the example, and keep the $VM variable as a single variable

So the $updatedVM variable is actually not needed 😊

You're right,I'll revert my commit.

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit d537bef into Azure:master Jun 19, 2020
dingmeng-xue pushed a commit that referenced this pull request Jun 20, 2020
* Example was missing Update-AzVM cmdlet

When running the example, the diagnostics settings were not applied to the VM, only to the variable stored in the Powershell windows at that moment. No real update was done on the VM.
For the diagnostics to be applied, the cmdlet Update-AzVM still needs to be executed

* Update Set-AzVMBootDiagnostic.md

* Update Set-AzVMBootDiagnostic.md

Co-authored-by: Yabo Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants