Skip to content

Conversation

@ariklin
Copy link
Contributor

@ariklin ariklin commented Jun 17, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/613

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@ariklin ariklin requested a review from chlahav June 17, 2020 13:31
@VeryEarly VeryEarly self-assigned this Jun 18, 2020
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • updated changelog, please only add new changes under upcoming release

  • sorry I didn't identify this in the design, please use singularity for cmdlet name:
    Get-AzSecurityTopologies -> Get-AzSecurityTopology

  • please fix failed test cases

@VeryEarly VeryEarly changed the title Introducing Az.Security SecurityTopologies cmdlets Introducing Az.Security SecurityTopology cmdlets Jun 19, 2020
@VeryEarly VeryEarly merged commit a631223 into Azure:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants