Skip to content

Conversation

@dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Jun 17, 2020

Description

Fix #12192

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@amolagar5
Copy link
Contributor

Is this change needed in tools/Common.Netcore.Dependencies.Test.targets too.

@erich-wang erich-wang merged commit 08ec671 into release-2020-06-23 Jun 17, 2020
@dingmeng-xue
Copy link
Member Author

Is this change needed in tools/Common.Netcore.Dependencies.Test.targets too.

no required because it references to Common.Netcore.Dependencies.targets

@dingmeng-xue dingmeng-xue deleted the sql/fix-12192 branch June 17, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph.Rbac/Version1_6/ActiveDirectory/ActiveDirectoryClient.cs does not handle guest users by mail

5 participants