Skip to content

HPC Cache - Fix ST Bug if flag is missing in cmdlet throw error. Fix ST documentation #12161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 3 commits into from
Jun 16, 2020
Merged

HPC Cache - Fix ST Bug if flag is missing in cmdlet throw error. Fix ST documentation #12161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c404be6
Fix bug in ST create, fix documentation for ST
rebecca-makar Jun 10, 2020
4a984b9
Merge pull request #1 from rebecca-makar/st_bug
rebecca-makar Jun 15, 2020
7fa65da
Update ChangeLog.md
VeryEarly Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/HPCCache/HPCCache/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Fixed bug for `New-AzHpcCacheStorageTarget` and help text.

## Version 0.1.0
* Preview of `Az.HPCCache` module
15 changes: 13 additions & 2 deletions src/HPCCache/HPCCache/Commands/NewAzHpcStorageTarget.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,18 @@ public override void ExecuteCmdlet()
this.Name,
() =>
{
this.storageTarget = this.CLFS.IsPresent ? this.CreateClfsStorageTargetParameters() : this.CreateNfsStorageTargetParameters();
if (this.CLFS.IsPresent)
{
this.storageTarget = this.CreateClfsStorageTargetParameters();
}
else if (this.NFS.IsPresent)
{
this.storageTarget = this.CreateNfsStorageTargetParameters();
}
else
{
throw new Exception(string.Format(Resources.CLFSorNFS));
}
if (this.IsParameterBound(c => c.Junction))
{
this.storageTarget.Junctions = new List<NamespaceJunction>();
Expand Down Expand Up @@ -170,7 +181,7 @@ private bool DoesStorageTargetExists()
this.CacheName,
this.Name);

throw new Exception(string.Format(Resources.UpgradeHpcCache, this.Name, this.CacheName));
throw new Exception(string.Format(Resources.StorageTargetAlreadyExist, this.Name, this.CacheName));
}
catch (CloudErrorException e)
{
Expand Down
9 changes: 9 additions & 0 deletions src/HPCCache/HPCCache/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/HPCCache/HPCCache/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="CLFSorNFS" xml:space="preserve">
<value>Need CLFS or NFS flag.</value>
</data>
<data name="ConfirmCreateStorageTarget" xml:space="preserve">
<value>Are you sure you want to create HPC cache storage target '{0}'?</value>
</data>
Expand Down
4 changes: 2 additions & 2 deletions src/HPCCache/HPCCache/help/New-AzHpcCacheStorageTarget.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ The **New-AzHpcCacheStorageTarget** cmdlet adds a Storage Target to Azure HPC Ca

### Example 1
```powershell
PS C:\> New-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -CLFS -StorageContainerID "/subscriptions/testsub/resourceGroups/testRG/providers/Microsoft.Storage/storageAccounts/testdstorageaccount/blobServices/default/containers/testcontainer" -Junctions @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/"})
PS C:\> New-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -CLFS -StorageContainerID "/subscriptions/testsub/resourceGroups/testRG/providers/Microsoft.Storage/storageAccounts/testdstorageaccount/blobServices/default/containers/testcontainer" -Junction @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/"})
```

### Example 2
```powershell
PS C:\> New-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -NFS -UsageModel "READ_HEAVY_INFREQ" -Junctions @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/"})
PS C:\> New-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -NFS -UsageModel "READ_HEAVY_INFREQ" -Junction @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/"})
```

## PARAMETERS
Expand Down
4 changes: 2 additions & 2 deletions src/HPCCache/HPCCache/help/Set-AzHpcCacheStorageTarget.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ The **Set-AzHpcCacheStorageTarget** cmdlet updates a Storage Target attached to

### Example 1
```powershell
PS C:\> Set-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -CLFS -Junctions @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/"})
PS C:\> Set-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -CLFS -Junction @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/"})
```

### Example 2
```powershell
PS C:\> Set-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -NFS -Junctions @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/export"})
PS C:\> Set-AzHpcCacheStorageTarget -ResourceGroupName testRG -CacheName testCache -StorageTargetName testST -NFS -Junction @(@{"namespacePath"="/msazure";"targetPath"="/";"nfsExport"="/export"})
```

## PARAMETERS
Expand Down