Skip to content

Conversation

@olrakovs-zz
Copy link
Contributor

@olrakovs-zz olrakovs-zz commented Jun 14, 2020

Description

General availability of Az.Marketplace module. With adding Privatestore cmdlets

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@olrakovs-zz
Copy link
Contributor Author

Related design review "Azure Marketplace Adding Privatestore cmdlets" #608

@VeryEarly VeryEarly self-assigned this Jun 15, 2020
@VeryEarly
Copy link
Collaborator

Az.Marketplace cannot be GA this time, please read the GA process:
https://github.com/Azure/azure-powershell-pr/wiki/Process-of-GA-module

@olrakovs-zz
Copy link
Contributor Author

@VeryEarly thank you for your comment , committed some changes for preview

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reference to the latest Az.Accounts-1.8.1?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this version to 0.1.0 (without '-preview')

@olrakovs-zz
Copy link
Contributor Author

Hey @VeryEarly who need to merge this pr?

@VeryEarly VeryEarly merged commit 3c9dfa6 into Azure:master Jun 16, 2020
@VeryEarly
Copy link
Collaborator

Hey @VeryEarly who need to merge this pr?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants