Skip to content

Conversation

@chenlei-yang
Copy link
Contributor

Description

Move ModuleFilter from VersionController to Tools.Common. Because In StaticAnalyzer, it also needs to use this tool. So I move this tool to Tools.Common, and fix the wrong places in StaticAnalyzer.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms self-assigned this Jun 11, 2020
@wyunchi-ms
Copy link
Contributor

LGTM

@wyunchi-ms wyunchi-ms merged commit 8f3a434 into Azure:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants