Replace Sql management client using generic rest client #11393
Conversation
|
Can one of the admins verify this patch? |
| else | ||
| { | ||
| IPage<PrivateLinkService> plsPage; | ||
| IPage<Microsoft.Azure.Management.Network.Models.PrivateLinkService> plsPage; |
There was a problem hiding this comment.
nit: suggest to use using namespace
There was a problem hiding this comment.
using this one now.
using NM = Microsoft.Azure.Management.Network.Models;
| /// the private endpoint connection.</param> | ||
| /// <param name="provisioningState">State of the private endpoint | ||
| /// connection.</param> | ||
| public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), PrivateEndpointProperty privateEndpoint = default(PrivateEndpointProperty), PrivateLinkServiceConnectionStateProperty privateLinkServiceConnectionState = default(PrivateLinkServiceConnectionStateProperty), string provisioningState = default(string)) |
There was a problem hiding this comment.
nit: usually we use null as default value for reference object instead of default(xxx), I guess this is generated code, so should be fine.
There was a problem hiding this comment.
copied from generated code.
|
|
||
| namespace Microsoft.Azure.Commands.Network.PrivateLinkService.PrivateLinkServiceProvider | ||
| { | ||
| public class PrivateLinkProviderFactory |
There was a problem hiding this comment.
mark this class as internal?
| switch (privateLinkResourceType.ToLower()) | ||
| { | ||
| case NETWORKING_TYPE: | ||
| default: |
There was a problem hiding this comment.
for unknown type, should we return error or throw exceptions?
There was a problem hiding this comment.
It's network original logic. If resource type is unknown, returns NetworkProvider.
|
|
||
| namespace Microsoft.Azure.Commands.Network.PrivateLinkService.PrivateLinkServiceProvider | ||
| { | ||
| public class GenericProvider : IPrivateLinkProvider |
Replace Sql management client using generic rest client
3 participants
Description
Replace Sql management client using generic rest client
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added