appgw: validate cert only if certificateFile is specified in set ssl cert command#10991
Closed
akshaysngupta wants to merge 5 commits intoAzure:network-marchfrom
Closed
appgw: validate cert only if certificateFile is specified in set ssl cert command#10991akshaysngupta wants to merge 5 commits intoAzure:network-marchfrom
akshaysngupta wants to merge 5 commits intoAzure:network-marchfrom
Conversation
markcowl
requested changes
Jan 31, 2020
...Network/ApplicationGateway/SslCertificate/SetAzureApplicationGatewaySslCertificateCommand.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
Hi @akshaysngupta , Could you please also update the changelog.md? |
6ea9eb6 to
39b19ea
Compare
13d9496 to
499b4d3
Compare
c049166 to
60689b5
Compare
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Hi @akshaysngupta, changes from |
Contributor
|
@akshaysngupta please re-create PR using |
|
Any idea what release this will be in? |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR majorly is to fix #9488
But as a part of this PR, we add a test in Network project using a KeyVault dataplane cmdlets. To make these cmdlets work, I am have made additional changes to Network Test Runner and KeyVault project. These changes help to mock the keyvault client in the Network project.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added