Skip to content

Adding Cmdlet New-AzApplicationGatewayRewriteRuleUrlConfiguration to support url rewrite capability for V2 application gateways#10877

Closed
abjai wants to merge 281 commits intoAzure:network-decemberfrom
abjai:urlrewrite
Closed

Adding Cmdlet New-AzApplicationGatewayRewriteRuleUrlConfiguration to support url rewrite capability for V2 application gateways#10877
abjai wants to merge 281 commits intoAzure:network-decemberfrom
abjai:urlrewrite

Conversation

@abjai
Copy link
Contributor

@abjai abjai commented Jan 13, 2020

Description

This should be released as a part of January 17 release.

Adding Support for UrlConfiguration under RewriteRuleActionset for Application Gateway Url Rewrite Feature

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Powershell design review link: Azure/azure-powershell-cmdlet-review-pr#339
Swagger PR: Azure/azure-rest-api-specs#7905

root and others added 30 commits November 6, 2019 15:52
@wyunchi1990
1. Fix the bug that can not find the right version PowerShellGet in s…
f0af88b 
…ome system.

2. Make sure will not contain the moudle which's version is lower than 1.0.0. And remove used json files in SerializedCmdlets.
@MECHANDR
Initial changes to support MinimumTlsVersion
e69e100
@MECHANDR
Initial test changes
14ec41f
@abkmr
updates for tests
6b6b2f5
@abkmr
update help
fa82f8d
@abkmr
help doc
405a2b7
@abkmr
updating help link
21bb253
@abkmr
adding examples
336c24c
@abkmr
Adding help examples for all
99ab956
@abkmr
updating exceptions for extra params
b0cbe7f
@digavino
Upgrade SDK package to latest version
39272e1
@digavino
Fix test cases
ed54b0d
@Only2125
Upgrading sdk version to 1.13.0 for Azure-reservations
7b9bd85
@MECHANDR
Fixing asserts.Updating session records to use latest API version whi…
a0a173d 
…ch is compatible with update .NET SDK nuget.
@digavino
Adding exclusions to WAF cmdlets
11a0f3a
@Cesarfgc
Add new dns label
dc03de9 
Add example to add a dns label to a public ip address
@Only2125
add purchase and calculatePrice
e2d6c4d
@Only2125
update help.md
7a61ca1
@MECHANDR
Addressing breaking change issue
618fe4a
@digavino
Update help files and readme
c020a2d
@MECHANDR
As suggested in design review, replacing ValidateSet with PSArgumentC…
405ef0f 
…ompleter
@digavino
Update help index
727c9ad
@Only2125
update
58ea30f
@Only2125
update url
a36808f
@Only2125
urlllll
f75d1f1
@Only2125
update
caeab05
@Only2125
update
473a88a
add Express Custom Setup support by Powershell
cd3c12d
@Only2125
resolve signatureError
8a0223a
@Only2125
staticError
d01a41d
MECHANDR and others added 18 commits December 5, 2019 13:34
@MECHANDR
Addressing PR comments
2e9607f
@MECHANDR
Merge branch 'master' into redis_2019_07_01_preview
19f31d7
@MECHANDR
Updating TestZoneRedundancy.json to avoid CredScan failure
4414374
@MECHANDR
Fixing CredScan
3fdbcca
@VeryEarly
Merge pull request #10523 from Cesarfgc/patch-1
70fcabe 
Add new dns label
@wyunchi-ms
Add suppression of TestZoneRedundancy.json
2da5998
@ssripadham
Cleaned up Option set and instead added validation in the code
3393738
@VeryEarly
Merge pull request #10659 from Azure/redis_2019_07_01_preview
f35e4d8 
Changes to support "ReplicasPerMaster" and "Instances"
@ssripadham
Pr comments
0575ad8
@VeryEarly
Merge pull request #10674 from Azure/ipgroup_azfw_branch
d4b0a2c 
AzureFirewall with IpGroups (LATEST)
@isra-fel
Update azure-powershell-developer-guide.md
2b50977
@msJinLei
Merge pull request #10679 from Azure/isra-fel-patch-2
28d9b36 
Update azure-powershell-developer-guide.md
@abjai
Url rewrite powershell changes
3fff1f6
@abjai
Merge branch 'urlrewrite' of https://github.com/abjai/azure-powershell …
9c911fe 
…into urlrewrite
@abjai
adding unit tests
46c9bcb
@abjai
updating md files and azure rm mapping
97b24f0
@abjai
Merge branch 'urlrewrite' of https://github.com/abjai/azure-powershell …
ceed552 
…into urlrewrite

# Conflicts:
#	src/Network/Network/ChangeLog.md
@abjai
Adding help files
24b238f
abjai
abjai commented Jan 13, 2020
View reviewed changes
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1
}
}

function Test-ApplicationGatewayCRUDRewriteRuleSetWithUrlConfiguration
Copy link
Contributor Author

@abjai abjai Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playback can not be done since the manifest for 2019-01-11 is not updated.

@abjai abjai requested a review from anton-evseev January 13, 2020 10:09
@isra-fel isra-fel self-assigned this Jan 14, 2020
@isra-fel
Copy link
Member

isra-fel commented Jan 14, 2020

Hi @abjai what did you mean by Jan 17 release? The ongoing release is on 1/28, see our milestones page

@anton-evseev
Copy link
Contributor

anton-evseev commented Jan 14, 2020

Please retarget to network-december

@abjai abjai changed the base branch from master to network-december January 14, 2020 14:15
@abjai
Copy link
Contributor Author

abjai commented Jan 14, 2020

Rebasing it to network december

@abjai abjai closed this Jan 14, 2020
@abjai
Copy link
Contributor Author

abjai commented Jan 14, 2020

Raised another PR to rebase to network-december

https://github.com/Azure/azure-powershell/pull/10894/files

@abjai
Copy link
Contributor Author

abjai commented Jan 14, 2020

Please retarget to network-december

Raised another PR https://github.com/Azure/azure-powershell/pull/10894/files

@abjai
Copy link
Contributor Author

abjai commented Jan 14, 2020

Hi @abjai what did you mean by Jan 17 release? The ongoing release is on 1/28, see our milestones page

Yes. I have rebased my branch to network-december. Please look at the PR here https://github.com/Azure/azure-powershell/pull/10894/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anton-evseev anton-evseev Awaiting requested review from anton-evseev

Assignees

@isra-fel isra-fel

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.